This is an automated email from the ASF dual-hosted git repository.
hello-stephen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e02d93d399f [fix](ivm) Rename leftover row binlog to changelog in IVM
tests (#69372)
e02d93d399f is described below
commit e02d93d399fca5d240ff7081c83010e5f6dc19fc
Author: yujun <[email protected]>
AuthorDate: Wed Oct 21 17:08:11 2026 +0800
[fix](ivm) Rename leftover row binlog to changelog in IVM tests (#69372)
Related PR: #69311, #69268, #63639
Problem Summary: #69311 renamed the row binlog (the change stream IVM
reads) to **changelog** and rejected the legacy keys `binlog.format` /
`binlog.need_historical_value` in every DDL. Two test files merged just
before it fell outside that rename sweep and now fail:
1.
`regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy`
(from #69268) — creates its IVM base tables with `"binlog.enable" =
"true", "binlog.format" = "ROW", "binlog.need_historical_value" =
"true"`, which CREATE TABLE now rejects.
2.
`RelationImpliedPredicateTest#testIvmOutputPredicatesSkipHiddenColumns`
(from #63639) — same legacy properties in the base-table DDL, and it
gates the creation on `enable_feature_binlog` instead of the new
`enable_feature_changelog`.
Fix: switch both to `"changelog.enable" = "true"` (plus
`"changelog.need_historical_value" = "true"` where the before-image is
needed), drop the rejected `binlog.format`, and use
`enable_feature_changelog` as the feature gate in the FE unit test.
Related IVM trace issue: https://github.com/apache/doris/issues/65418 .
---
.../apache/doris/nereids/mv/RelationImpliedPredicateTest.java | 10 +++++-----
.../suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy | 10 ++++------
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/mv/RelationImpliedPredicateTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/mv/RelationImpliedPredicateTest.java
index 72c3b257b36..20b21225f83 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/mv/RelationImpliedPredicateTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/mv/RelationImpliedPredicateTest.java
@@ -414,17 +414,17 @@ public class RelationImpliedPredicateTest extends
SqlTestBase {
void testIvmOutputPredicatesSkipHiddenColumns(boolean showHiddenColumns)
throws Exception {
initMvRewriteSession();
boolean originalEnableTableStream = Config.enable_table_stream;
- boolean originalEnableFeatureBinlog = Config.enable_feature_binlog;
+ boolean originalEnableFeatureChangelog =
Config.enable_feature_changelog;
boolean originalShowHiddenColumns =
connectContext.getSessionVariable().showHiddenColumns();
Config.enable_table_stream = true;
- // master gates ROW-binlog table creation behind
enable_feature_binlog; the IVM base table needs it.
- Config.enable_feature_binlog = true;
+ // master gates changelog table creation behind
enable_feature_changelog; the IVM base table needs it.
+ Config.enable_feature_changelog = true;
try {
dropMvByNereids("drop materialized view if exists
mv_relation_implied_ivm");
dropTableWithSql("drop table if exists relation_implied_ivm_base");
createTable("create table relation_implied_ivm_base (id bigint,
score bigint) "
+ "duplicate key(id) distributed by hash(id) buckets 1 "
- + "properties('replication_num' = '1', 'binlog.enable' =
'true', 'binlog.format' = 'ROW')");
+ + "properties('replication_num' = '1', 'changelog.enable'
= 'true')");
createMvByNereids("create materialized view
mv_relation_implied_ivm "
+ "BUILD DEFERRED REFRESH INCREMENTAL ON MANUAL\n"
+ "DISTRIBUTED BY RANDOM BUCKETS 1\n"
@@ -458,7 +458,7 @@ public class RelationImpliedPredicateTest extends
SqlTestBase {
} finally {
connectContext.getSessionVariable().setShowHiddenColumns(originalShowHiddenColumns);
Config.enable_table_stream = originalEnableTableStream;
- Config.enable_feature_binlog = originalEnableFeatureBinlog;
+ Config.enable_feature_changelog = originalEnableFeatureChangelog;
dropMvByNereids("drop materialized view if exists
mv_relation_implied_ivm");
dropTableWithSql("drop table if exists relation_implied_ivm_base");
}
diff --git
a/regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy
b/regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy
index c27da16c8da..7d7795b6c48 100644
--- a/regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy
+++ b/regression-test/suites/mtmv_p0/ivm/test_ivm_datetime_sequence.groovy
@@ -48,9 +48,8 @@ suite("test_ivm_datetime_sequence") {
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "true",
- "binlog.enable" = "true",
- "binlog.format" = "ROW",
- "binlog.need_historical_value" = "true",
+ "changelog.enable" = "true",
+ "changelog.need_historical_value" = "true",
"function_column.sequence_col" = "seq_dt"
)
"""
@@ -64,9 +63,8 @@ suite("test_ivm_datetime_sequence") {
PROPERTIES (
"replication_num" = "1",
"enable_unique_key_merge_on_write" = "true",
- "binlog.enable" = "true",
- "binlog.format" = "ROW",
- "binlog.need_historical_value" = "true"
+ "changelog.enable" = "true",
+ "changelog.need_historical_value" = "true"
)
"""
sql """
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
