mrhhsg commented on PR #68032:
URL: https://github.com/apache/doris/pull/68032#issuecomment-6330349986
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68032
commit: 2811649fa760e18cbcdd6e61e86e30ad607bdbba
base: 85adcce350bf4ece48955daa7ac426bef53a892f
reviewed_at: 2026-10-22T09:20+08:00
reviewer: mrhhsg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 5, nit: 13}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-07 (observability, Regression: yes)
`fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadRuntimeStatusMgr.java:183-188`
— ordinary SELECT now waits for final BE reports without retaining already
received contributions; TTL expiry can permanently understate even existing
scan/CPU/local-spill audit counters. Minor after independent consequence
challenge: these are best-effort diagnostic logs/table/plugin values, not a
demonstrated business-result, transaction or quota control path.
Retain/snapshot contributions or declare this limitation; not merely delayed
display.
- F-01/F-03/F-05 (Minor, test coverage) — production vault resolution and S3
manager initialization remain ungated, and capacity-failure tests do not assert
close/unreadability before destruction. Existing mock coverage is extensive but
not a real-provider or mixed-FE E2E validation.
- F-04 (Minor, non-regression performance)
`be/src/exec/spill/spill_file_writer.cpp:203-210` — append-only failure
performs an avoidable LIST even though close was never attempted; uncertain
publication after an attempted close still requires reconciliation.
- All 18 findings are inherited and revalidated (5 Minor, 13 Nit), with no
new Blocker/Major. Known concurrent forwarded-cancel, old-serving REST and
best-effort report/shutdown limitations remain deduplicated, not declared
fixed. Incomplete MPU cleanup requires explicitly configured bucket lifecycle.
Static review only: no build/tests/SQL were run; this receipt does not override
GitHub reviews or pending CI.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
