github-actions[bot] commented on code in PR #67178: URL: https://github.com/apache/doris/pull/67178#discussion_r4345457702
########## be/src/common/config.cpp: ########## @@ -524,10 +524,10 @@ DEFINE_mDouble(compaction_promotion_ratio, "0.05"); DEFINE_mInt64(compaction_promotion_min_size_mbytes, "128"); // When output rowset of cumulative compaction total version count (end_version - start_version) -// exceed this config count, the rowset will be moved to base compaction -// NOTE: this config will work for unique key merge-on-write table only, to reduce version count -// related cost on delete bitmap more effectively. -DEFINE_mInt64(compaction_promotion_version_count, "1000"); +// exceed this config count, the rowset will be moved to base compaction. +// NOTE: this config only works for unique key merge-on-write tables. The default maximum value +// disables version-count-based promotion while retaining the option to enable it when needed. +DEFINE_mInt64(compaction_promotion_version_count, "9223372036854775807"); Review Comment: [P2] Preserve the safeguard when bitmap aggregation is disabled With `enable_agg_and_remove_pre_rowsets_delete_bitmap=false` (a supported configuration), tiny updates to distinct keys in an existing large MoW base rowset leave separate `(base_rowset, segment, load_version)` bitmap entries. Local stale-rowset cleanup and cloud pre-rowset aggregation both skip coalescing these entries when that flag is off. If cumulative outputs stay below the size threshold and contain no delete predicate, this maximum also prevents their version spans from moving them into base compaction. Bitmap memory, and the bitmap serialized by local `save_meta()`, can therefore grow across many thousands of loads; the old finite threshold let base compaction retire those versions. Please retain a finite promotion safeguard when aggregation is disabled and add coverage for that configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
