hubgeter opened a new pull request, #69449:
URL: https://github.com/apache/doris/pull/69449

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Related PR: N/A
   
   Problem Summary:
   `ALTER TABLE ... CREATE BRANCH ... RETAIN <time>` was mapped to 
`max-snapshot-age-ms` instead of `max-ref-age-ms`. When both `RETAIN` and `WITH 
SNAPSHOT RETENTION ... <time>` were specified, the two time values were 
swapped. This change maps `RETAIN` to the branch reference age and the snapshot 
retention time to the snapshot age, matching the Iceberg Spark implementation. 
Unit tests cover the option conversion, DDL routing, and the resulting Iceberg 
snapshot reference metadata.
   
   ### Release note
   
   Fix Iceberg branch metadata so `RETAIN` sets `max-ref-age-ms` and the 
snapshot retention time sets `max-snapshot-age-ms`.
   
   ### Check List (For Author)
   
   - Test
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
   - Behavior changed:
       - [ ] No.
       - [x] Yes.
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to