morningman commented on code in PR #16818:
URL: https://github.com/apache/doris/pull/16818#discussion_r1111263184
##########
be/src/vec/columns/column_string.h:
##########
@@ -280,6 +280,52 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
}
}
+#define MAX_STRINGS_OVERFLOW_SIZE 128
+ template <typename T, size_t copy_length>
+ void insert_many_strings_fixed_length(const StringRef* strings, size_t num)
+ __attribute__((noinline));
+
+ template <size_t copy_length>
+ void insert_many_strings_fixed_length(const StringRef* strings, size_t
num) {
Review Comment:
Please add some comment about these methods.
eg, when to use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
