airborne12 opened a new pull request, #429:
URL: https://github.com/apache/doris-thirdparty/pull/429
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary:
The macOS jobs of the CI of clucene-2.1 do not pass, independent of the code
that is changed:
- The root CMakeLists.txt requires CMake 2.4.0. The CMake of the macOS
runners (4.x) has dropped the compatibility with versions below 3.5 and stops
with "Compatibility with CMake < 3.5 has been removed from CMake", so both the
macOS build and the macOS unit test job fail while configuring. The minimum is
raised to 3.12, as in clucene and clucene-3.1. The project configures, builds
and passes cl_test with CMake 4.4.
- `TestStandard95.cpp` defines a global `std::vector<std::string> tokens`
and `TestTermVectorsReader.cpp` another one of a different type. With libstdc++
the type of the first one is part of the symbol name (`tokens[abi:cxx11]`),
with libc++ both are just `_tokens`, so on macOS cl_test fails to link with
"duplicate symbol '_tokens'". The first one is made `static`.
### Release note
None
### Check List (For Author)
- Test: No need to test (CI configuration and test code only)
- Not run on macOS (not available here); cl_test builds and passes on
Linux with g++ 11 and CMake 4.4.
- Behavior changed: No
- Does this need documentation: No
Note: the unit test of the macOS job only passes together with #424 (the
pick of #421). Before it, `testPFOR.cpp` includes `for/vp4.h` through the
include path `src/ext/*`, which the CMake of the macOS runner does not expand,
and the test does not compile (on any platform whose CMake quotes that path).
#424 removes that dependency. This change was checked on top of #424.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
