github-actions[bot] commented on code in PR #69516:
URL: https://github.com/apache/doris/pull/69516#discussion_r4357585450
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -3052,21 +3072,22 @@ public TStreamLoadPutResult
streamLoadPut(TStreamLoadPutRequest request) {
}
String groupCommitMode = request.getGroupCommitMode();
- if (groupCommitMode != null && !groupCommitMode.equals("off_mode") &&
Env.getCurrentEnv().isMaster()
- && Config.enable_forward_group_commit_stream_load_to_follower)
{
- TStreamLoadPutResult result =
forwardGroupCommitStreamLoad(request);
- if (result != null) {
- return result;
- }
- }
-
TStreamLoadPutResult result = new TStreamLoadPutResult();
TStatus status = new TStatus(TStatusCode.OK);
result.setStatus(status);
StreamLoadHandler streamLoadHandler = new StreamLoadHandler(request,
null, result, clientAddr);
try {
+ checkGroupCommitStreamLoadAuth(request);
Review Comment:
[P2] Fence follower replay before rechecking load credentials
With `enable_forward_group_commit_stream_load_to_follower` enabled in a
non-cloud cluster, change an existing load user's password on the master and
submit an explicit sync/async group-commit load using the new password before a
live follower replays that edit. The master passes this check, but the
forwarded `streamLoadPut` runs it again against the follower's old password and
returns `ANALYSIS_ERROR`. Follower selection checks only `isAlive()`, and
`forwardGroupCommitStreamLoad` returns application errors directly, so local
fallback never runs. Previously this ordinary follower planning path did not
authenticate again. Fence follower replay against the master's auth metadata,
or safely retry the master-authenticated request locally on this rejection; add
a forwarding/password-change test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
