morningman commented on code in PR #69488:
URL: https://github.com/apache/doris/pull/69488#discussion_r4357865730
##########
fe/fe-connector/fe-connector-hive/src/main/java/org/apache/doris/connector/hive/HiveConnectorMetadata.java:
##########
@@ -625,7 +625,8 @@ public ConnectorTableSchema getTableSchema(
ConnectorCapability.SUPPORTS_NESTED_COLUMN_PRUNE,
ConnectorCapability.SUPPORTS_FIELD_ID_ACCESS_PATH,
ConnectorCapability.SUPPORTS_STORAGE_PREDICATE_PRUNING,
- ConnectorCapability.SUPPORTS_NESTED_COLUMN_SCHEMA_CHANGE));
+ ConnectorCapability.SUPPORTS_NESTED_COLUMN_SCHEMA_CHANGE,
+ ConnectorCapability.SUPPORTS_WRITE_ONLY_DEFAULTS));
Review Comment:
Not in this PR. `HiveConnectorMetadata#getTableSchema(session, handle,
snapshot)` returns the sibling's schema without `reflectSiblingCapabilities`
for every inherited capability, not only this one (auto-analyze, Top-N lazy
materialization, nested column prune, field-id access path, storage predicate
pruning, nested column DDL); that predates this PR. So for a time-travel read
of an iceberg-on-HMS table, `SELECT DEFAULT(c) ... FOR VERSION AS OF` keeps
master's current answer (NULL) instead of the new error; nothing is written.
Reflecting capabilities on the snapshot path changes scan planning for all of
them and should come with its own tests, so it is left to a separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
