github-actions[bot] commented on code in PR #69592:
URL: https://github.com/apache/doris/pull/69592#discussion_r4371999865
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -662,6 +663,10 @@ private Plan
bindTVFTableSink(MatchingContext<UnboundTVFTableSink<Plan>> ctx) {
"INSERT INTO TVF only supports local/s3/hdfs, but got: " +
tvfName);
}
+ if (tvfName.equals(LocalTableValuedFunction.NAME)) {
+ LocalTableValuedFunction.checkAccess(ctx.connectContext);
Review Comment:
[P2] Opt the existing LOCAL sink test into the new flag
`BindTVFTableSinkTest.duplicateOutputNamesKeepDistinctPositions` still
analyzes `INSERT INTO local(...) SELECT 1 AS x, 2 AS x` without setting
`Config.enable_local_tvf`. With the new default of `false`, this call now
throws `LOCAL TVF is disabled` before the test can assert that the two output
ExprIds remain distinct. The FE Surefire configuration uses `reuseForks=false`,
so setup in the new test class cannot enable LOCAL for this existing class.
Explicitly enable and restore the flag in that existing test with an authorized
context, preserving both the new production gate and the duplicate-output
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
