stinger1206 commented on PR #67720: URL: https://github.com/apache/doris/pull/67720#issuecomment-6501118318
Thank you @airborne12! Both suggestions are taken in d07b797f0d: 1. Dropped the stale `segment_ptr->_footer_pb.reset();` in `GetSegmentFooterPropagatesIoContext` — the cache `erase()` right before it alone forces the reload now. 2. Ported `SegmentFooterCacheTest.ConcurrentGetSegmentFooterWithEviction` from #69811 (with the `get_metadata_size()` check dropped, since this PR's `get_metadata_size()` no longer reads the footer at all). Also closing the loop on your note: the PR description now lists the unit test and credits you for the original reproducer — thanks for testing that workload under ASAN and for closing #69811 in favor of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
