github-actions[bot] commented on code in PR #69874:
URL: https://github.com/apache/doris/pull/69874#discussion_r4420412731
##########
fe/fe-connector/fe-connector-adbc/src/test/java/org/apache/doris/connector/adbc/AdbcClientTest.java:
##########
@@ -74,6 +89,139 @@ void usingAClosedClientFailsLoud(@TempDir Path tempDir) {
Assertions.assertTrue(e.getMessage().contains("closed"),
e.getMessage());
}
Review Comment:
[P1] Move this real ArrowReader materialization test out of FE unit tests
(or replace it with a non-native fake). AdbcNativeTestSupport explicitly
documents that tests which iterate an ArrowReader must live in the ADBC
regression suites because the arrow-c-data JNI shim requires CXXABI_1.3.9 and
makes FE unit tests fail on supported CentOS 7 hosts. This test calls
getObjects and AdbcObjectsReader.readNamespaces on the native SQLite path, so
the connector unit suite will fail on those hosts before it can verify the
lifecycle fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
