OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4430599469
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -1375,6 +1392,32 @@ public void setTableProperties(ConnectorSession session,
ConnectorTableHandle ha
}
}
+ private static boolean containsFormatProperty(Map<String, String>
properties) {
+ return properties.containsKey("write-format")
+ || properties.containsKey(TableProperties.DEFAULT_FILE_FORMAT)
+ || properties.containsKey(TableProperties.FORMAT_VERSION);
+ }
+
+ private static int getEffectiveFormatVersion(Table table, Map<String,
String> properties) {
+ String version = properties.get(TableProperties.FORMAT_VERSION);
+ if (version == null) {
+ return getFormatVersion(table);
+ }
+ try {
+ return Integer.parseInt(version);
+ } catch (NumberFormatException ignored) {
+ return getFormatVersion(table);
+ }
+ }
+
Review Comment:
Fixed by merging existing and incoming properties before applying the
writer's nickname precedence. Added both mixed-key directions, nickname repair,
and actual Geometry/Geography writes for scalar and nested columns.
Ordinary-key/spatial-value support is preserved.
Commit:
[1409690bec50](https://github.com/apache/doris/commit/1409690bec5058c709b4016ba16af2189c30ed04).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
