Gabriel39 commented on code in PR #69671:
URL: https://github.com/apache/doris/pull/69671#discussion_r4438456124
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:
##########
@@ -1284,6 +1290,7 @@ protected void convertPredicate() {
scanNodeProperties = null;
cachedPropertiesResult = null;
filteredToOriginalIndex = null;
+ partitionProofConjuncts = null;
}
/**
Review Comment:
Fixed in 3e25989230f. The common `setScanParams` path now wraps
`getTableFormatType`, `populateRangeParams`, and
`getPartitionEnforcedConjuncts` in the existing `onPluginClassLoader` scope,
using the selected scan provider's loader. This covers eager conversion and
conversion on batch worker threads, and restores the caller TCCL in `finally`
when any callback fails.
Added eight tests covering query and worker threads, successful conversion,
and a failure from each of the three callbacks. They fail without the wrapper
and pass with it; the failure cases also verify unchanged exception propagation
and caller TCCL restoration. Validation passed: 312 FE scan/Stream tests, 85
selected SPI tests including surface gates, 301 Iceberg planner/range/proof
tests, and FE Checkstyle.
Also rebased onto master `378404eeb1`, preserving master file-path error
context and this PR's split-local predicate filtering. Full BE runtime tests
remain for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
