morningman commented on code in PR #69488:
URL: https://github.com/apache/doris/pull/69488#discussion_r4443654252
##########
fe/fe-connector/fe-connector-hive/src/main/java/org/apache/doris/connector/hive/HiveConnectorMetadata.java:
##########
@@ -625,7 +625,8 @@ public ConnectorTableSchema getTableSchema(
ConnectorCapability.SUPPORTS_NESTED_COLUMN_PRUNE,
ConnectorCapability.SUPPORTS_FIELD_ID_ACCESS_PATH,
ConnectorCapability.SUPPORTS_STORAGE_PREDICATE_PRUNING,
- ConnectorCapability.SUPPORTS_NESTED_COLUMN_SCHEMA_CHANGE));
+ ConnectorCapability.SUPPORTS_NESTED_COLUMN_SCHEMA_CHANGE,
+ ConnectorCapability.SUPPORTS_WRITE_ONLY_DEFAULTS));
Review Comment:
Follow-up: fixed in #69999. The snapshot overload of `getTableSchema` now
reflects the same inherited capabilities as the two-argument one (both go
through one helper), so an iceberg-on-HMS table keeps them in every statement
that pins a snapshot: explicit time travel, and since #69299 the
latest-snapshot pin as well. Checked on a local cluster against a Hive 3.1.2
metastore: through the HMS catalog, `SELECT DEFAULT(d) FROM t FOR VERSION AS OF
<snapshot>` now fails with `DEFAULT(d) must reference a column of the table
that this statement writes`, as it does through an Iceberg catalog, and `UPDATE
... WHERE d = DEFAULT(d)` and `MERGE ... ON ... AND t.d = DEFAULT(t.d)` now
update the rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
