morningman commented on PR #69821: URL: https://github.com/apache/doris/pull/69821#issuecomment-6568440838
Closing this PR. #69723 (merged on 2026-11-02) removed the legacy file scanner together with the V1 Iceberg reader code this PR fixed (`equality_delete.cpp`, `iceberg_reader_mixin.h` and both test files), so nothing is left to change on master. Plans from an FE older than 4.1.4, which send no `iceberg_scan_semantics_version`, now go through FileScannerV2, which builds a missing equality-delete key as a NULL literal or an initial-default expression instead of repeating a one-row column. I will cover that V2 path for such plans (top-level, composite and nested missing keys, Parquet and ORC) in a follow-up test PR. The V1 defect still exists on branch-4.1 and branch-4.2 and is tracked separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
