raghav-reglobe commented on PR #69219:
URL: https://github.com/apache/doris/pull/69219#issuecomment-6586149133
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69219
commit: 312e0354a8093a8b2c8d1cc5d7348db7afd68d27
base: f937d950d45313f20864d287df453e1b90f5c615
reviewed_at: 2026-11-03T00:46+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 2, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`regression-test/suites/variant_p0/test_variant_double_text_roundtrip.groovy:35`
— Minor: the text leg pins four determined strings with `assertEquals` instead
of a `qt_` block with a generated `.out` (the Testing Standards' rule 6); a
`qt_` would pin the same seven-key document text, since a STRING cell is
compared exactly. The parity leg must stay `assertEquals` with delta 0, because
the framework's 1e-8 DOUBLE tolerance cannot tell 1997.6 from
1997.6000000000001.
- The two regenerated `test_all_prdefine_type_to_sparse` expectations were
verified by content (byte-equal to the base under the exact substitution
8.119999999999999→8.12 / 9.119999999999999→9.12, 70 lines each) and every other
numeric token re-derived under the new writer, not by running the suites; the
float strings were re-derived from fmt 7.1.3's shortest-form path. Not verified
locally: no build or test run.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
