raghav-reglobe commented on PR #67672:
URL: https://github.com/apache/doris/pull/67672#issuecomment-6595472580
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67672
commit: 815fb022174b77b2da4a78985f9dfad494978955
base: 46798454678d67c8dc47b048e9a6675ca79669bd
reviewed_at: 2026-11-03T09:58+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 2
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserRoleManager.java:131`
— Nit: the two-argument `getRolesByUser(UserIdentity, boolean)` lost its last
caller when Auth's wrapper went; worth deleting in a follow-up so no
un-narrowed role resolver stays reachable.
- Reviewed as the unpushed candidate (21 commits ahead of 39e05e62a311)
right before this fast-forward push; both earlier local runs of this PR (heads
39e05e6 and e579984) were inherited — 30 of their 31 code findings are closed
at this head, the 31st was the PR body, corrected with this push.
- Review threads T1–T9 are all addressed at this head; T9's second half (the
privilege check `listTableMetadataNameIds` runs on an executor thread) was
closed in this round by carrying the RPC narrowing onto that thread.
- Design call: EXPORT and CREATE JOB (ON STREAMING / ON SCHEDULE) are
refused in a narrowed session rather than persisting the narrowing into the
job; persisting it is a possible follow-up.
- Not verified locally: no build and no test run (no JDK on the review
machine); compile correctness and the test expectations were walked by reading.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
