mrhhsg opened a new pull request, #70128:
URL: https://github.com/apache/doris/pull/70128

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Related PR: N/A
   
   Problem Summary: S3 batch deletion previously requested quiet results and 
treated a successful request without explicit per-object errors as proof that 
every requested object had been deleted. A partial response could leave a spill 
object behind while cleanup released its accounting and skipped the pending 
retry.
   
   This change requests verbose deletion results and checks that every 
requested key appears in the returned `Deleted` list for its batch. Missing 
confirmation returns an error with the bucket, key, request ID, and 
confirmation counts. Existing spill cleanup can then retain the pending 
deletion and retry it after the underlying deletion failure is resolved.
   
   ### Release note
   
   S3 batch deletion now reports an error if any requested object lacks 
deletion confirmation.
   
   ### Check List (For Author)
   
   - Test: Unit Test: `./run-be-ut.sh --run 
--filter='S3ObjStorageClientMockTest.*:SpillFileS3Test.*' -j 32` (53 tests 
passed).
   - Test: Regression test: `./run-regression-test.sh --conf 
regression-test/conf/regression-conf.groovy --run -d spill_p0 -s 
window_function_spill` (1 suite passed; SQL smoke test, not a live object-store 
fault test).
   - Test: `./build.sh --be --fe -j 32` and `./build.sh --be -j 32` passed. 
Formatting, build-hygiene, and clang-tidy checks passed.
   - Test: `./build.sh --cloud -j 32` did not complete because a local FDB 
library was unavailable at link time; the changed shared source compiled. Live 
object-store end-to-end validation was not run.
   - Behavior changed: Yes. Incomplete S3 batch deletion responses no longer 
report success.
   - Does this need documentation: No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to