Gabriel39 commented on PR #70192:
URL: https://github.com/apache/doris/pull/70192#issuecomment-6629045643
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70192
commit: 7e8fa587a222dbdf9bb39a70b58f37257e253ae9
base: 0eb5131db62cd7939788508377fc148df6ac1ef1
reviewed_at: 2026-11-04T19:05+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `docker/thirdparties/docker-compose/iceberg/encryption/prepare-jars.sh:39`
and `:53`: the previously reported fixture jar-readability issue is fixed for
fresh downloads and private caches; readable shared caches avoid chmod.
-
`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergAuthenticatedFileIO.java:100`:
all four typed descriptors retain SDK encryption metadata inside
authentication. Encrypted SQL execution remains guarded.
- Static review of all 17 changed files; no build or test was run during
this review. Nine prior dismissals were re-confirmed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
