wyxxxcat commented on PR #70119: URL: https://github.com/apache/doris/pull/70119#issuecomment-6621824039
Clarification of my earlier review: the accessor-selection code correctly implements the batch-delete setting: - `enable_gcs_batch_delete_object=true` (default): `S3Accessor` → `DeleteObjects` → batch deletion. - `enable_gcs_batch_delete_object=false`: `GcsAccessor` → `DeleteObject` → individual-object deletion. My earlier wording made this sound like an implementation defect. The remaining observation concerns the PR description and release note, which state that disabling the setting retains `S3Accessor` and that individual-object deletion is the default. Those statements should be updated to match the behavior above. Suggested wording: > GCS recycling retains generic S3 batch deletion by default. Set `enable_gcs_batch_delete_object=false` at startup to use `GcsAccessor` for individual-object deletion of file lists and prefixes. At reviewed head `0dc8be88f466e868adc14b28dd922aff07139f01`, no additional code defects were confirmed within the requested review scope. Testing concerns and continuing to scan after a failed deletion are excluded as requested. No change to the accessor-selection code is needed for the intended behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
