yujun777 commented on code in PR #69896:
URL: https://github.com/apache/doris/pull/69896#discussion_r4462701422
##########
be/src/storage/task/engine_publish_version_task.cpp:
##########
@@ -317,6 +335,10 @@ Status EnginePublishVersionTask::execute() {
}
}
}
+ for (const RowsetSharedPtr& changelog_rowset : attached_changelog_rowsets)
{
+ const RowsetMetaSharedPtr& rowset_meta =
changelog_rowset->rowset_meta();
+ tablet_id_to_num_delta_rows.insert({rowset_meta->tablet_id(),
rowset_meta->num_rows()});
Review Comment:
Changelog has not been officially released yet, and there are no changelog
tablets in production. Therefore, the rolling-upgrade compatibility scenario
described here does not arise. Compatibility between unreleased changelog
implementations is outside the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
