mrhhsg commented on PR #70191:
URL: https://github.com/apache/doris/pull/70191#issuecomment-6627080357

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70191
   commit: c48851d70ead5df13b05ff8a59d8a22a1e31b0f1
   base: 37671319cdefc44dd8e5b85a0584a4826460f03d
   reviewed_at: 2026-11-04T17:10+08:00
   reviewer: mrhhsg
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - All 11 changed files and 17 critical checkpoints have qualified static 
coverage, including a fresh qualified review of BE/SQL and the final tuple-0 
boundary. This receipt does not assert full CI or runtime validation.
   - 
`fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/LogicalResultSinkToShortCircuitPointQuery.java:51-76`:
 complex and nontrivial projections deliberately use normal planning, including 
when nested pruning is disabled; simple scalar slots/literals retain 
eligibility.
   - `be/src/service/point_query_executor.cpp:139-148`: every nonempty 
all/predicate access-path list is rejected, including legacy whole-column DATA 
roots and scalar META requests. There is no automatic normal-plan fallback and 
no general fix for old-FE no-path complex-schema evolution or 
producer-schema-aware row caching.
   - Author-provided focused results are FE 28/28 and ASAN BE 12/12; reviewers 
did not rerun tests. Final-snapshot SQL regression, complete server binaries, 
live mixed-version deployment and performance benchmarks were not rerun.
   - 
`regression-test/suites/point_query_p0/test_rowstore_nested_pruning_minimal.groovy:147-204`:
 prepared-result assertions do not establish fast-path/cache hits; the 
missing-key rollup case checks descriptor initialization, not populated-rollup 
decoding.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to