hubgeter commented on PR #69704:
URL: https://github.com/apache/doris/pull/69704#issuecomment-6599981499
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69704
commit: cb0aa4ef3d128c6d78a67d2fd440034106c1da5b
base: 21f37fe182295601a774467857f315bd427a1ab3
reviewed_at: 2026-11-03T17:27+08:00
reviewer: hubgeter
model: gpt-6.1-sol
effort: max
findings: {blocker: 0, major: 0, minor: 0, nit: 2}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorTransaction.java:740`
— Old BE producers retain the legacy undercount for standalone DELETE when
data rows exist; the correction adds the known new-producer subset. Pure DELETE
preserves the complete mixed-producer total.
- `be/src/exec/sink/viceberg_merge_sink.cpp:86` — Count correctness was
reviewed under Doris's one-mutating-source-row-per-target MERGE contract.
Existing execution versions below 11 skip cardinality validation;
duplicate-target inputs can still yield different counts under those legacy
semantics. See the [Doris MERGE
notes](https://doris.apache.org/docs/dev/lakehouse/catalogs/iceberg-catalog/#merge-into).
- Read-only source review: no local build, unit test, SQL regression, live
mixed-version cluster or failure injection was executed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
