github-actions[bot] commented on code in PR #70066: URL: https://github.com/apache/doris/pull/70066#discussion_r4462544712
########## AGENTS.md: ########## @@ -20,7 +20,7 @@ Separately, any new outbound HTTP request the FE or BE issues to a host named by ## Thrift and Protobuf Field Ids -Every change under `gensrc/thrift` and `gensrc/proto` must keep every upgrade compatible (branch-3.1 → 4.0 → 4.1 → 4.2 → master): a field id or enum value means the same thing on every branch, an id is never reused, and a new field is optional. The rule and how to review against it are in `gensrc/AGENTS.md`; read it before touching those directories. +Every change under `gensrc/thrift` and `gensrc/proto` must keep every upgrade compatible (branch-3.1 → 4.0 → 4.1 → 4.2 → master): a field id or enum value means the same thing on every branch, an id is never reused, and a new field is optional. A new id or enum value is added on master first; a release-branch PR that adds one master does not have is not mergeable. The rule and how to review against it are in `gensrc/AGENTS.md`; read it before touching those directories. Review Comment: [P2] Make the master-first release-branch condition explicit. This line currently says "a release-branch PR that adds one master does not have is not mergeable," which omits the id/enum object and is ambiguous. Please mirror the precise rule from gensrc/AGENTS.md (for example, "a release-branch PR that adds an id or enum value that master does not already have is not mergeable") so the root summary cannot be misread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
