jacktengg commented on PR #69776:
URL: https://github.com/apache/doris/pull/69776#issuecomment-6666295196
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69776
commit: e6e49990dffbaca323c38c4fc7a79b1f53bd7b43
base: bff68004fda41c0649efc9de4c5d14df29069440
reviewed_at: 2026-11-06T02:45+08:00
reviewer: jacktengg
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/TopnFilterPushDownVisitor.java:183`
— Nit: update the PR body to describe grouping-slot aggregate traversal and
per-target inclusive/strict modes. The final saved validation is 17 FE tests,
36 BE tests and eight regression suites; the body still lists earlier counts.
No code defect remains open.
- `be/src/runtime/query_context.cpp:161` — Full 30-file review and all 17
checkpoints are complete. Strict mode requires a proven target path to a
one-key heap source; aggregate/native merging paths retain equality. Previously
tracked generic inclusive-pushdown issues and mixed FE/BE versions remain
outside the agreed scope.
- Reviewers inspected saved official build/test/style logs and final source
hashes; they did not rerun builds or tests. The review converged in round 1.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
