924060929 commented on code in PR #69255:
URL: https://github.com/apache/doris/pull/69255#discussion_r4465896618
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -554,6 +558,7 @@ public void dropDb(String dbName, boolean ifExists, boolean
force) throws DdlExc
unlock();
}
+ FunctionUtil.cleanUdfCache(functionSignatures);
Review Comment:
@linrrzqqq Keeping the Function ID on RECOVER is correct; changing it is not
required to address this. The issue is retiring package resources on a
recoverable DROP: if an old query still retains the package, RECOVER succeeds,
but a newly analyzed query using the restored function fails with "is being
deleted" until the old references are released.
Function identity and cache-instance lifetime can be handled separately. For
example, defer destructive package cleanup for recoverable databases, or
distinguish cache generations while keeping the Function ID (including delayed
cleanup tasks and periodic reconciliation). This does not require copy
semantics. We can defer this P2 if we accept the temporary post-RECOVER
unavailability, but preserving the ID alone does not make that behavior
unavoidable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
