xylaaaaa commented on issue #69884: URL: https://github.com/apache/doris/issues/69884#issuecomment-6676116470
Added local mixed-catalog coverage for the CAST fix: commit `0b9c149de8`, following `a20f5343e7`. Both commits remain local and have not been pushed to PR #69904. `test_deltalake_hms_mixed_cast` reads Delta and Iceberg tables in the same HMS database through a single `type=hms` catalog. It covers UNION ALL, JOIN, both table orders, and synchronous/streaming execution. The UNION ALL branches avoid join-derived predicates, so the Iceberg branch's only possible pushdown comes from its CAST condition. - Delta `CAST(decimal AS BIGINT) = 123` retains both files and returns `123.45`. Adding an independent `decimal < 124` condition selects one of two files. - Iceberg uses integral decimal fixtures (`123.00`, `999.00`) as a safe control for its existing policy. Its CAST-derived predicate remains in EXPLAIN in both modes; synchronous execution selects one of two files. Iceberg does not publish its SDK file counters on the streaming path, so streaming verification uses its plan and actual results. - Both JOIN orders return `(123.45, 123, 123.00)`. Reversing the UNION ALL branches preserves both matching rows. - Framework generation and an ordinary rerun passed all 14 independently checked result blocks, with an unchanged golden hash. Existing Delta CAST coverage (24 blocks) and basic coverage (36 blocks) also passed. - All 108 targeted FE tests passed with no skips, including new scans sharing one metadata instance and controls for Hive routing, Paimon, Iceberg, JDBC, Delta and SPI. FE Checkstyle passed. This commit adds tests only. The separately confirmed Iceberg lossy-CAST issue remains open: master `8442911b266b1a5d01e9cf1f2c932ea778a28b1f` fails its existing disabled `decimalToDoubleComparisonMustNotPruneMatchingRows` test when enabled. It has been recorded in the local TODO with evidence and acceptance criteria. The safe integral-decimal control above is not a fix or acceptance test for that issue; its full SQL reproduction remains pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
