924060929 commented on PR #63612:
URL: https://github.com/apache/doris/pull/63612#issuecomment-6676990598
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#63612
commit: 34af6f3e1f2d09a7e5ef122a0f7edcf4713badd8
base: b6c67510385391d0dd913589f1b323ec86ba7bd6
reviewed_at: 2026-11-06T12:34+08:00
reviewer: 924060929
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 3
converged: true
```
**Notes for maintainers**
- Full fresh solo review of all 44 changed paths this turn. The first round
found a dependency-registration correctness issue; after repair, two clean
rounds rechecked the final head. The other 42 bodies are byte-identical after
normalized comparison with this turn's full reading; both updated bodies were
read in full. No subagents.
- Fixed a pre-existing producer race required by the new invalidation path:
concurrent first registrations could replace another MV's dependency set. All
three `MTMVRelationManager` indexes now use atomic `computeIfAbsent`;
add-new-before-prune-old ordering, rewrite generation barriers and per-cache
failure isolation remain unchanged. No global lock, companion journal or
live-query registry was added.
- Identical deterministic test source fails all three interleavings before
repair and passes all six class cases after it, including downstream table/view
invalidation reaching both MVs. Preset FE validation passes 21 classes / 258
cases, with zero failures, errors or skips. `build.sh --fe`, integrated
Checkstyle and `git diff --check` pass; validated source hashes match this
commit. Builds/tests occurred in the repair phase; final review was read-only.
- Old-head External Regression build 1094474 failed the `doris_be --version`
package probe because `libjvm.so` could not be loaded, before regression cases.
Its precise agent/package configuration was not changed or claimed fixed.
Old-head partial FE UT progress is not credited as validation of this new
commit. New remote CI/review remains a separate gate; no full FE/P0, BE/Cloud,
new remote-cluster regression or benchmark run is claimed here.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
