hubgeter commented on PR #70016:
URL: https://github.com/apache/doris/pull/70016#issuecomment-6621897376
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70016
commit: 7a4620c7cf442b038e9928d14ad46dfdd18f13c3
base: 736649fcb41544ef977bb7677a1e6a5df5b7996b
reviewed_at: 2026-11-04T03:39+00:00
reviewer: hubgeter
model: gpt-6.1-sol
effort: max
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModel.java:225` —
Selected pinned partition rows affect physical FileScan CPU only; retained
Filter/Join cardinality and column original lineage keep the baseline contract.
Previous F-01/F-02 remain fixed.
- `fe/fe-connector/pom.xml:58` — API 30.0 retains both upstream typed
table-absence errors and this row carrier; connector plugins require a matching
rebuild. The merged MetadataRead boundary preserves pin ownership and failure
propagation.
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/mvcc/PluginDrivenMvccSnapshot.java:282`
— Costing reads only already-materialized RANGE rows for the exact table
reference. Unknown/delete-affected/native/deferred/unavailable paths retain
existing fallback.
- Full review covered 14/14 files, re-confirmed 23 inherited dismissal
entries and converged in one round. This review ran no builds or Doris tests;
separate exact-head implementation validation passed 539 focused tests in 48
classes and Checkstyle. Customer SQL/cluster A/B, a guaranteed final MV winner
and full FE/provider packaging remain unverified.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
