deardeng opened a new pull request, #70181:
URL: https://github.com/apache/doris/pull/70181
Problem Summary: If a backend stays offline for three agent-task health
checks before receiving a publish task, offline cleanup removes the task and
marks it finished/ABORTED. The committed transaction still records that its
publish tasks were sent, while tablet-report republishing requires an error
tablet list that an undelivered task does not have. The transaction can remain
invisible even after the backend recovers.
Keep publish tasks in the agent queue during offline cleanup so the existing
task-report path can resend them. Preserve partial publish results and retain
the existing successful-response and VISIBLE-transaction cleanup paths,
including cleanup for a backend that remains offline.
Fix committed transactions remaining invisible after backends recover from
prolonged outages that trigger agent-task cleanup.
- Test: Unit Test / Build
- run-fe-ut.sh: AgentTaskCleanupDaemonTest, AgentTaskTest and
PublishVersionTaskTest; all 12 tests pass
- The 3 new tests fail on the original code because publish tasks are
removed
- build.sh --fe -j4 passes, including Checkstyle
- Live network-isolation regression not run; FE component tests cover
cleanup, resend and terminal cleanup
- Behavior changed: Yes, offline cleanup retains publish tasks for retry
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]