AshinGau commented on code in PR #17054:
URL: https://github.com/apache/doris/pull/17054#discussion_r1115289306
##########
be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.h:
##########
@@ -100,6 +100,8 @@ class ColumnChunkReader {
// only used when maintaining the consistency of _remaining_num_values.
Status skip_values(size_t num_values, bool skip_data = true);
+ void get_uncompressed_levels(const tparquet::DataPageHeaderV2& page_v2,
Slice& page_data);
Review Comment:
Be a private method
##########
be/src/vec/exec/format/parquet/level_decoder.cpp:
##########
@@ -20,6 +20,8 @@
#include "util/bit_util.h"
#include "util/coding.h"
+const size_t V1_LEVEL_SIZE = 4;
Review Comment:
It's better to be a static constexpr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
