github-actions[bot] commented on code in PR #70319:
URL: https://github.com/apache/doris/pull/70319#discussion_r4488893681


##########
contrib/apache-orc:
##########
@@ -1 +1 @@
-Subproject commit be0f1b73a7aeb78824a03e0dcb692c50a176d513
+Subproject commit 5962bb071d6345cc29c5353d64d85a203525e4d9

Review Comment:
   [P1] Link libdeflate on ARM64 when advancing the ORC revision
   
   This revision also removes the architecture guards around ORC's libdeflate 
ZLIB decoder, so `Compression.cc` now calls `libdeflate_alloc_decompressor`, 
`libdeflate_deflate_decompress` and `libdeflate_free_decompressor` on 
AArch64/arm64. However, `be/cmake/thirdparty.cmake:189-192` still adds 
`deflate` only for x86/x86_64, and the ORC CMake target does not link it 
either. Consequently the BE link on ARM64 has unresolved libdeflate symbols. 
Include the corresponding ARM64 link-dependency change with this submodule 
update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to