924060929 commented on code in PR #63612:
URL: https://github.com/apache/doris/pull/63612#discussion_r4489680290
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -2682,6 +2682,7 @@ private boolean
updateCatalogAfterVisible(TransactionState transactionState, Dat
long versionTime = entry.getValue().getMiddle();
OlapTable table = entry.getValue().getRight();
table.updateVisibleVersionAndTime(version, versionTime);
+ env.onTableChanged(table, Env.TableChangeType.DATA);
Review Comment:
Fixed in 73108578c43ecebe4675e0203f7d023bf607092a. Removed the redundant
VISIBLE -> DATA -> whole-cache scan, together with the unused DATA
enum/overload and scan API. Native live publication and replay now only publish
the existing partition/table versions under table write locks; FE/BE cache
admission and lookup share dependency validation against those versions.
Changed entries are rejected/evicted when queried, while unchanged partition
dependencies remain reusable. Metadata-only replay still advances revisions and
performs exception-isolated cache fanout.
The same deterministic no-cache-visit test fails on the previous
implementation (getUsedTables called by invalidateAboutTableData during
serialized VISIBLE replay) and passes after the fix. Additional real lookup
controls cover modified/unmodified partitions, another table, table-wide
fallback and partitioned/nonpartitioned COMMITTED versus VISIBLE. Preset
validation passes 13 FE classes / 210 cases with no failures, errors or skips;
build.sh --fe, integrated Checkstyle and git diff --check pass. No benchmark
claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
