raghav-reglobe commented on PR #67672: URL: https://github.com/apache/doris/pull/67672#issuecomment-6595482249
@morningman thank you for the rebase and the fix on top. I pushed 21 commits as a fast-forward on your head 39e05e6 (none of your commits are rewritten). Per thread: - **T1** `getGrantedRoleNames` reads under the Auth read lock. - **T2** the forward carries `authenticated_user_ident` (`TMasterOpRequest` 37), so the master's audit row names the authenticating account; the REST AFTER_QUERY path sets it the same way. - **T3** an omitted `WITH ROLES` clause clears the switcher's own lane instead of inheriting it. - **T4** the revert runs before `resetSessionVariable`. - **T5** `foldContextDependentExpressions` is guarded for a narrowed session. - **T6** the mixed-build gate is keyed on the destination FE of every forward (including the KILL and SHOW PROCESSLIST fan-outs and the all-FE `information_schema` scans), and every FE journals its build in the heartbeat response so followers can judge it. - **T7** `getUserRoleWorkloadGroupPrivs` resolves through the narrowed resolver. - **T8** `TShowUserRequest.current_roles` (id 2); `showUser` is wrapped and the BE sends it. - **T9** every `TGetTables`-family handler is wrapped, and `listTableMetadataNameIds` now carries the narrowing onto its executor thread (that was the half still open after the first pass). Beyond the threads, two rounds of the local pipeline-style review (receipt above) drove the rest of the delta: the compute-group placement widening tests the bit a CLUSTER grant is stored under, the forward refuses a switched request without a role list, and the fail-closed list grew. One design call to flag: EXPORT and CREATE JOB (ON STREAMING / ON SCHEDULE) are **refused** in a narrowed session rather than persisting the narrowing into the job; if you would rather have the narrowing persisted, that is a follow-up PR I am happy to do. The PR body is updated accordingly (fresh vs reserved thrift ids, the MySQL-protocol-only revert, the refusal list). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
