platoneko opened a new pull request, #17086: URL: https://github.com/apache/doris/pull/17086
# Proposed changes Issue Number: close #xxx ## Problem summary This PR is to solve such situations: ``` Replica A is cooldown replica，cooldown_meta_id=1 Replica B: cooldown_replica=A, cooldown_meta_id=1 After tablet report, FE finds all cooldown_meta_id=1 Replica A: cooldown_date, cooldown_meta_id=2 Replica A shutdown, FE choose Replica B as cooldown replica Replica B, Thread1: cooldown_replica=A, follow_cooldown_data Replica B, Thread2: update_cooldown_conf, cooldown_replica=B Replica B, Thread3: confirm_unused_remote_files success, deletes some cooldowned data of cooldown_meta_id=2 Replica B, Thread1: follow_cooldown_data success, cooldown_meta_id=2, but some cooldowned data has been deleted ``` To solve above situation, MUST serialize update_cooldown_conf and follow_cooldown_data. ``` Replica A is cooldown replica，cooldown_meta_id=1 Replica B: cooldown_replica=A, cooldown_meta_id=1 Replica C: cooldown_replica=A, cooldown_meta_id=1 After tablet report, FE finds all cooldown_meta_id=1 Replica A: cooldown_date, cooldown_meta_id=2 Replica A shutdown, FE choose Replica B as cooldown replica Replica B: update_cooldown_conf, cooldown_replica=B Replica B: confirm_unused_remote_files success, deletes some cooldowned data of cooldown_meta_id=2 Replica C: cooldown_replica=A, follow_cooldown_data, cooldown_meta_id=2, but some cooldowned data has been deleted Replica C: update_cooldown_conf, cooldown_replica=B ``` To solve above situation, MUST check that all replica's `cooldownReplicaId` matches this tablet's `cooldownReplicaId` when FE confirms unused remote files. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [[email protected]](mailto:[email protected]) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
