morningman opened a new pull request, #70490:
URL: https://github.com/apache/doris/pull/70490

   ### Background
   
   The Doris 4.1 all-in-one build script assembles base and full images from the
   FE, BE and meta-service component images. It supports an OCI image index with
   amd64 and arm64 variants and permits an explicit single-platform override.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: None
   PR Type: Build/CI/Chore
   
   Problem Summary:
   
   Without --platform, the script previously built only the Docker host's
   architecture. Default to linux/amd64,linux/arm64 so a normal component-image
   build produces both variants. Update the help and README examples and reject
   multi-platform builds from a directory containing single-architecture 
binaries.
   
   ### Details
   
   - **Affected:** docker/runtime/all-in-one/4.1/build.sh and its README.
   - **Developer and release impact:** The default builds both architectures for
     both flavors. Single-platform builds still use --platform. Local output,
     release tarballs and --test require a matching single platform. 
Multi-platform
     local builds continue to require the containerd image store; --push retains
     registry output support.
   - **License and third-party:** None.
   - **Rollback:** Restore the previous platform default and associated 
examples.
   
   ### Testing
   
   - bash -n and ShellCheck passed for the build script; git diff --check 
passed.
   - Eleven offline checks with a temporary Docker substitute passed: default
     platforms for both flavor tags, explicit amd64 and arm64 overrides, push
     without containerd, rejection of the classic store and multi-platform smoke
     tests, rejection of multi-platform local output and tarballs, 
single-platform
     directory builds, and the help text.
   - Actual image builds and runtime smoke tests remain unverified because 
Docker
     Hub access returned EOF and Service Unavailable errors.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: Yes (see Details).
   - Does this need documentation: Yes; updated the all-in-one README and help.
   - Pre-submission status: Partially verified: actual image builds and runtime 
smoke tests require working Docker Hub access.
   
   ### AI Disclosure
   
   - Tool: Codex (GPT-6).
   - Generated: Build script changes, README updates, offline checks and this 
description.
   - Human review: Pending author review.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to