github-actions[bot] commented on code in PR #70488: URL: https://github.com/apache/doris/pull/70488#discussion_r4545779272
########## regression-test/suites/search/test_search_bkd_skip_threshold.groovy: ########## @@ -0,0 +1,87 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// A numeric (BKD) leaf that matches more than inverted_index_skip_threshold percent of a +// segment used to return INVERTED_INDEX_BYPASS. SEARCH has no row-by-row path, so the +// query failed with "SEARCH cannot fall back to row execution". SEARCH must always use +// the index. +suite("test_search_bkd_skip_threshold", "p0") { + def tableName = "test_search_bkd_skip_threshold" + + sql """ set enable_common_expr_pushdown = true """ + sql """ set enable_inverted_index_query_cache = true """ + sql """ set inverted_index_skip_threshold = 50 """ + sql """ set default_variant_enable_typed_paths_to_sparse = false """ + sql """ set default_variant_enable_doc_mode = false """ + + sql "DROP TABLE IF EXISTS ${tableName}" + sql """ + CREATE TABLE ${tableName} ( + `id` INT NOT NULL, + `k` INT NULL, + `v` variant NULL, Review Comment: [P2] Pin the Variant subcolumn budget for this fixture The p0 pipeline enables fuzzy session variables, and `SessionVariable.initFuzzyModeVariables()` can leave `default_variant_max_subcolumns_count=1` with nested groups disabled. This untyped `VARIANT` inherits that budget even after the suite disables doc mode. Both `n` and `p` occur in all ten rows, so `select_variant_paths()` materializes only `p` and sends `n` to sparse storage. The first `search('v.n:5')` then fails with `SEARCH index unavailable for Variant field 'v.n'`, independently of the threshold fix, making this new p0 test flaky. Pin the budget to at least 2 (or 0 for unlimited) before CREATE, or declare both paths explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
