github-actions[bot] commented on code in PR #69995:
URL: https://github.com/apache/doris/pull/69995#discussion_r4545898744


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -4346,6 +4346,11 @@ private static void addOlapTablePropertyInfo(OlapTable 
olapTable, StringBuilder
         
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_DISABLE_AUTO_COMPACTION).append("\"
 = \"");
         sb.append(olapTable.disableAutoCompaction()).append("\"");
 
+        if (olapTable.getVariantEscapeDotsInKeys()) {
+            
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_VARIANT_ESCAPE_DOTS_IN_KEYS)
+                    .append("\" = \"true\"");

Review Comment:
   [P2] Preserve the policy in copy-tablet DDL too
   
   `ADMIN COPY TABLET` calls `getDdlStmt` with a concrete replica version. Its 
`specificVersion != -1` branch emits only `replication_num`/`version_info` and 
returns before this renderer, so the returned `CreateTableStmt` recreates an 
escaped source with the default legacy policy. Replaying that DDL and inserting 
`parse_to_variant('{"a.b":1}')` stores `{"a":{"b":1}}`, preventing faithful 
reproduction. Emit this immutable property in the versioned DDL branch as well 
and cover `getDdlStmt` with `specificVersion` set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to