hello-stephen opened a new pull request, #70531:
URL: https://github.com/apache/doris/pull/70531

   ### Background
   
   GitHub PR comments select TeamCity pipelines through the existing shell 
helper and file filters. Each pipeline resolves its own target branch and 
artifacts using the requested PR revision.
   
   ### What problem does this PR solve?
   
   Issue Number: None
   Related PR: #70515 (current comment dispatch)
   PR Type: Build/CI/Chore
   
   Problem Summary:
   
   Use a single two-parameter contract for comment submissions: PR_NUMBER and 
COMMIT_ID. TeamCity keeps the exact native VCS revision; pipeline-side code 
handles branch lookup and package checks. This aligns direct regression 
requests with the coordinated pipeline artifact migration.
   
   ### Details
   
   - **Affected:** TeamCity comment submission helper and its tests.
   - **Developer and release impact:** All comment-triggered jobs receive only 
env.PR_NUMBER and env.COMMIT_ID as explicit business parameters. File filters, 
skip buildall, command routing, master-only Performance, authentication and 
native revision checks remain unchanged. A direct run p0 still submits only P0.
   - **License and third-party:** No new dependencies.
   - **Rollback:** Revert the helper change together with the corresponding 
pipeline input contract if needed.
   - **Behavior change:** Stop passing CI_BRANCH and CI_REQUESTED_PR_HEAD; 
pipelines obtain the target branch from trusted PR metadata and verify 
COMMIT_ID against the native revision.
   
   ### Testing
   
   - All 27 existing helper/workflow tests passed, including updated exact 
parameter assertions, direct regression dispatch, command/branch selection, 
file filters, skip buildall and authentication redaction.
   - actionlint, shellcheck -S warning, bash -n and git diff --check passed.
   - Live buildall and direct run p0 validation remain pending pipeline 
deployment and merge into the default branch.
   
   ### Notes for Reviewers
   
   The TeamCity configurations must support the new input contract before this 
change is merged. Compile publication and regression package lookup are 
maintained in those configurations, outside this PR.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Behavior changed: Yes (see Details)
   - Does this need documentation: No
   - Pre-submission status: Partially verified: local checks passed; 
coordinated pipeline deployment and live comment verification pending.
   
   ### AI Disclosure
   
   - Tool: OpenAI Codex
   - Generated: Helper parameter change, test assertions and this description.
   - Human review: Pending maintainer review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to