eldenmoon commented on PR #69995:
URL: https://github.com/apache/doris/pull/69995#issuecomment-6850297805
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69995
commit: 535c366403102d0a09b6a10c6e2c32c51fcb7aaf
base: 9e598d38789571a7fc30652aa054f035bd4f1184
reviewed_at: 2026-11-13T18:21+08:00
reviewer: eldenmoon
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- F-02 and F-03 are fixed at this head. CTAS now deliberately omits source
VARIANT storage templates for every inferred Variant output, including
same-policy/default-legacy CTAS, while retaining the other eight parameters and
leaving source metadata unchanged; later writes no longer inherit
source-template coercion/materialization. See `CreateTableCommand.java:185-188`
and `VariantType.java:136-141`.
- F-04 (Minor, test-coverage): `ExpressionTranslatorTest.java:204-205`
verifies the nested same-spy `toVariantStoragePath` call instead of the storage
lookup count. Use `descriptor.getSubColLables()` as the argument. The semantic
index-identity assertions remain valid; this is not a production defect or the
former deterministic FEUT failure.
- Existing legacy tables/data and the reviewed protocol/storage contract
remain unchanged. Escaped tables require every FE and BE to be upgraded;
mixed-version escaped operation and downgrade remain unsupported.
- Incremental static review: all 121 current PR paths covered, with 115
content-identical paths inherited from the prior completed review and affected
dependencies reopened. No local builds/tests were run. The latest observed
current-head CI is pending/queued; author-reported validation is separate from
this review.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
