924060929 commented on PR #70397: URL: https://github.com/apache/doris/pull/70397#issuecomment-6848915413
### Local CI repair review — validated locally Commit: `47a2a994283b10422d878de27c6ca0ca1e5311f0` (branch-4.1). The synchronous-MV regression fills base-table SQL caches before creating rollups. On this branch, `RollupJobV2.onFinished` publishes the index, rebuilds the schema and calls `Env.onTableChanged`, so the old cache entries must be invalidated. The regression still expected them to survive, matching the cause of [the actual branch-4.2 P0 failure](https://8.218.164.131/buildConfiguration/Doris_P0/3344). This branch has the same three obsolete expectations. One shared helper now requires misses after MV publication, re-executes the same queries, then requires cache hits. It covers the rename, create-with-insert and drop-with-insert scenarios, preserving their later rename/insert/drop checks. Only the regression script changes; production code and golden results are unchanged. Validation performed independently in the branch-4.1 worktree: - `./run-fe-ut.sh --run org.apache.doris.alter.RollupJobV2Test,org.apache.doris.qe.TableCacheInvalidationTest`: **40 passed**, zero failures/errors/skips. The rollup test explicitly checks eviction of a cache populated while the shadow index is invisible. - `./build.sh --fe`: passed with integrated Checkstyle (UI disabled). - `./run-regression-test.sh --compile`: passed. The modified Groovy suite compiled using this worktree's own regression framework classpath. - `git diff --check`: passed. One clean solo review of the repair diff and branch-native call chain; no actionable findings. This is a focused repair review, not a fresh full-PR review. - End-to-end regression was **not** executed locally: this isolated worktree has no BE binary. A new CI run must validate the suite. The previous branch-4.1 [FEUT 2832 failure was a CI preflight ownership refusal](https://github.com/apache/doris/pull/70397#issuecomment-6826549092); compilation and tests did not run there. It is not evidence of a source failure and is not claimed fixed by this test change. Remote gates will be retriggered for this commit. No all-green or merge-readiness claim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
