github-actions[bot] commented on code in PR #70331:
URL: https://github.com/apache/doris/pull/70331#discussion_r4561365555
##########
docker/thirdparties/run-thirdparties-docker.sh:
##########
@@ -1734,7 +1734,11 @@ start_polaris() {
register_stack_metadata "polaris" "${POLARIS_DIR}/docker-compose.yaml" ""
compose_cmd "${POLARIS_DIR}/docker-compose.yaml" "" down --remove-orphans
if [[ "${STOP}" -ne 1 ]]; then
- compose_cmd "${POLARIS_DIR}/docker-compose.yaml" "" up -d --wait
--remove-orphans
+ # polaris-init is a one-shot service. Keep it out of `up --wait`,
+ # otherwise Compose reports the successfully exited container as a
+ # failed stack startup.
+ compose_cmd "${POLARIS_DIR}/docker-compose.yaml" "" up -d --wait
--remove-orphans polaris
+ compose_cmd "${POLARIS_DIR}/docker-compose.yaml" "" run --rm --no-deps
polaris-init
Review Comment:
[P1] Make the initializer terminate before running it in the foreground
At this head, `docker-compose/polaris/init-catalog.sh:145-146` creates
`/tmp/polaris_initialized` and then executes `tail -f /dev/null`; the Compose
service mounts and executes that script unchanged. After successful setup this
foreground `compose run` therefore never exits (`--rm` only removes the
container after exit; see the [Docker run
reference](https://docs.docker.com/reference/cli/docker/compose/run/)).
`start_polaris` stays alive, so `wait_for_started_jobs` never finishes and
`run-thirdparties-docker.sh -c polaris` hangs before subsequent External suites
can run. The previous `up -d --wait` could return once the sentinel healthcheck
passed. Make the initializer exit successfully in this change, or retain
health-based startup for this long-lived service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
