yujun777 commented on PR #70561:
URL: https://github.com/apache/doris/pull/70561#issuecomment-6848264814

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70561
   commit: 1308f418e7898693e36e85cbd4eb173594ff4f8d
   base: ee73acc6131e6c6c752eb59e252404590be6ad77
   reviewed_at: 2026-11-13T16:44+08:00
   reviewer: yujun777
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandler.java:557`
 — Specialization uses original-relation uniqueness over direct equality slots; 
nonunique, expression, residual and FULL OUTER paths retain their existing 
repair logic.
   - 
`fe/fe-core/src/main/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandler.java:590`
 — Internal SUM is created after MV normalization; business aggregate 
classification, normalized signature, original detail events and repair 
sequence contracts remain unchanged.
   - Existing validation logs inspected: FE/ASAN BE builds, Checkstyle, 194 
focused FE tests and 7 regression suites passed; real chained LEFT/RIGHT plans 
use SUM without repair ANTI joins. Formal review itself was read-only.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to