yiguolei commented on PR #67720:
URL: https://github.com/apache/doris/pull/67720#issuecomment-6909104401

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#67720
   commit: d36fef9cb4cf5cab8f7f75d4fc3d728a25b01140
   base: 0c29961f45ee976ef61c6a5dfe7b38b40a6ec131
   reviewed_at: 2026-11-16T14:24+08:00
   reviewer: yiguolei
   model: gpt-6-astra
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - Existing review context remains open: [cache-pressure / retained-footer 
accounting 
discussion](https://github.com/apache/doris/pull/67720#issuecomment-6599421692).
 `be/test/storage/segment/segment_footer_cache_test.cpp:380-443` proves 
retained-footer validity and cache-entry bookkeeping, not accounting until the 
last reader releases the footer or acceptable workload latency. The cache 
wrapper uncharges at eviction while readers can retain the old object; a later 
miss can parse another copy. [The author reports no representative comparison 
yet](https://github.com/apache/doris/pull/67720#issuecomment-6891441214). This 
review does not close that concern or provide an unconditional 
memory/performance sign-off; the finding counts cover new distinct issues.
   - `be/src/storage/segment/segment.cpp:1378` copies the footer shared_ptr 
while its PageCacheHandle is live. I traced hit/miss, concurrent 
erase/replacement, disabled-cache ownership, normalization before publication, 
and scalar/Variant/traversal callers; no new lifetime or publication defect was 
found.
   - `be/test/storage/segment/segment_footer_cache_test.cpp:290-377` verifies 
LRU recency with measured single-shard capacity, A-survives/B-evicted checks, 
and no extra parse on a hit. Cache-policy and SyncPoint guards restore state on 
normal and fatal-assert exits. The eight-thread eviction test provides stress 
coverage, not a deterministic proof of every schedule.
   - Static review only: all four changed files and relevant callers/cache 
implementations were covered in one converged round by two coverage reviewers 
plus lead verification. No builds, tests, sanitizers, or benchmarks were run in 
this review; the author's reported ASAN results were not independently repeated.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to