morningman opened a new pull request, #70832: URL: https://github.com/apache/doris/pull/70832
### Background PR automation warns about large files, assigns reviewer candidates, and maintains the `code-review` commit status. These tasks currently use `pull_request_target` to obtain repository permissions and, for reviewer selection, Codex credentials. ### What problem does this PR solve? Issue Number: None Related PR: None PR Type: Build/CI/Chore Problem Summary: GitHub will [block `pull_request_target` by default in public repositories on December 2](https://github.blog/changelog/2026-11-02-pull_request_target-blocked-by-default-december-2/). Large-file warnings and review-status synchronization now receive PR events through an unprivileged relay, with writes performed by trusted `workflow_run` consumers. Reviewer assignment now requires the exact `/assign-reviewers` comment from a repository writer. The supporting resolver and tests handle fork runs without PR metadata, closed PRs, stale and previous heads, authorization, and retry compatibility; auto cherry-picking stays outside this change. ### Details - **Change map:** All changes are CI/tooling: +663/-53 lines. This includes +327/-13 test lines and +5/-3 documentation lines; the remaining +331/-37 lines implement event routing, validation, permission checks, and CI coverage. No Doris runtime code or submodule pins change. - **Affected:** GitHub Actions on Ubuntu, Python 3 helpers, large-file warnings, reviewer assignment, and review-status synchronization. - **Developer and release impact:** Use `/assign-reviewers` instead of applying `need-reviewers`; repeated commands select again, while a retry of the same run preserves its choices. Manual selection previews remain read-only. PR relays are subject to the repository's fork-workflow approval settings. Release builds are unchanged. - **License and third-party:** No new dependencies, runtime artifacts, or license changes. - **Rollback:** Revert this PR. Restored `pull_request_target` workflows require an applicable allow policy after GitHub starts enforcement. - **CI permissions and secrets:** The relay has no repository permissions, checkout, or secrets. The trusted resolver has only Actions/content/PR read access and downloads metadata from the triggering run. Consumers re-read live GitHub data before writing; assignment checks current writer permission before preparing Codex inputs and again before applying a plan. Existing credentials are reused. - **Behavior change:** Assignment is requested by a new exact command comment rather than a label. Large-file checks remain warning-only. Status synchronization retains closed-PR and previous-head handling, including shared-head contexts. ### Testing - Executed the offline script from `reviewer-assignment-check.yml` locally on macOS ARM64: 181 tests passed, including real relay/resolver CLI and warning-comment steps, invalid metadata rejection, assignment authorization, retries, and status resolution. - `PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s .github/scripts -p test_review_convergence_workflow.py`: 2 tests passed locally, covering the existing review-source/aggregation contract. ### Notes for Reviewers The artifact carries routing hints, never review approval. The receiver binds the PR to GitHub's run/PR data and recomputes statuses from live PRs and existing scoped review sources. The old `before` SHA can only select another commit to recompute. Live GitHub-hosted event delivery and production credentials were not exercised locally; both consumers must be present on the default branch for `workflow_run` delivery. ### Release note None ### Check List (For Author) - Behavior changed: Yes (see Details) - Does this need documentation: No (developer command documentation is updated in `tools/reviewer-routing/README.md`) - Pre-submission status: Partially verified: GitHub-hosted event delivery and production credentials have not been exercised. ### AI Disclosure - Tool: Codex (GPT-6) - Generated: Implementation, tests, developer documentation, and this description. - Human review: not stated - Prompts: The author selected PR-event relays for large-file warnings and review-status synchronization, and the `/assign-reviewers` command for assignment. They requested development on a new branch from the latest master and submission of a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
