yiguolei commented on code in PR #17989:
URL: https://github.com/apache/doris/pull/17989#discussion_r1143348857
##########
be/src/vec/columns/column_string.h:
##########
@@ -63,8 +63,11 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
void ALWAYS_INLINE check_chars_length(size_t total_length, size_t
element_number) const {
if (UNLIKELY(total_length > MAX_STRING_SIZE)) {
- LOG(FATAL) << "string column length is too large: total_length="
<< total_length
- << " ,element_number=" << element_number;
+ throw Exception(
+ fmt::format(
+ "string column length is too large:
total_length={}, element_number={}",
Review Comment:
Exception(int code, const std::string_view fmt, Args&&... args)
: Exception(code, fmt::format(fmt, std::forward<Args>(args)...))
{}
exception will format the message automatically. Do not need call fmt here.
AND use ErrorCode::xxx instead of TStatusCode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
