github-actions[bot] commented on PR #18625:
URL: https://github.com/apache/doris/pull/18625#issuecomment-1506364931
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/4685802380";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 256:
if [ $exit_code -ne 0 ]; then
^------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests
in Bash/Ksh.
^--------^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^--------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "$exit_code" -ne 0 ]]; then
In build.sh line 257:
mkdir -p ${DORIS_HOME}/be/src/apache-orc
^-----------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
mkdir -p "${DORIS_HOME}"/be/src/apache-orc
In build.sh line 258:
curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz | tar
-xz -C ${DORIS_HOME}/be/src/apache-orc --strip-components=1
^-----------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz | tar
-xz -C "${DORIS_HOME}"/be/src/apache-orc --strip-components=1
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when
v...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -254,8 +254,8 @@
exit_code=$?
set -e
if [ $exit_code -ne 0 ]; then
- mkdir -p ${DORIS_HOME}/be/src/apache-orc
- curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz | tar
-xz -C ${DORIS_HOME}/be/src/apache-orc --strip-components=1
+ mkdir -p ${DORIS_HOME}/be/src/apache-orc
+ curl -L
https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz | tar
-xz -C ${DORIS_HOME}/be/src/apache-orc --strip-components=1
fi
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
