morningman commented on code in PR #18636:
URL: https://github.com/apache/doris/pull/18636#discussion_r1165546876
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/FileQueryScanNode.java:
##########
@@ -114,9 +116,10 @@ public void init() throws UserException {
backendPolicy.init();
numNodes = backendPolicy.numBackends();
- context = scanProvider.createContext(analyzer);
- context.createDestSlotMap();
- context.conjuncts = conjuncts;
+ initParamCreateContexts();
+ // context = scanProvider.createContext(analyzer);
Review Comment:
delete if unused.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/FileQueryScanNode.java:
##########
@@ -203,24 +206,40 @@ private void initFunctionGenTable(FunctionGenTable table,
ExternalFileTableValue
}
// Create a corresponding ParamCreateContext
- private void initParamCreateContexts(Analyzer analyzer) throws
UserException {
- context = scanProvider.createContext(analyzer);
- context.createDestSlotMap();
- context.conjuncts = conjuncts;
+ private void initParamCreateContexts() throws UserException {
Review Comment:
The method name should be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
