CalvinKirs opened a new pull request, #18666:
URL: https://github.com/apache/doris/pull/18666
# Proposed changes
Issue Number: close #xxx
## Problem summary
`commons-lang `(1and2) is no longer maintained since 2011, and the official
recommendation is `commons-lang3`, which can be smoothly upgraded to be
compatible with `commons-lang`.
We use both dependencies in `fe`, which can be completely unified.
`PatternGenerator#generateTypePattern `has many meaningless loops, and
IntegerRange is introduced for, which is unnecessary. So I refactored it.
## Describe your changes.
- Use commons-lang3 uniformly
- Add the check that prohibits commons-lang in checkstyle
- Refactor PatternGenerator#generateTypePattern to reduce meaningless method
loops
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[[email protected]](mailto:[email protected]) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]