morningman commented on code in PR #18696:
URL: https://github.com/apache/doris/pull/18696#discussion_r1167930960
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -941,7 +941,20 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) thr
}
}
- if (healthReplicaNum < quorumReplicaNum) {
+ if (transactionState.isPublishTimeout() &&
healthReplicaNum > 0) {
+ // We can not do any thing except retrying,
+ // because publish task is assigned a version,
+ // and doris does not permit discontinuous
+ // versions.
+ //
+ // If a timeout happens, it means that the
rowset
+ // that are being publised exists on a few
replicas we should go
Review Comment:
```suggestion
// that are being published exists on a few
replicas we should go
```
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -941,7 +941,20 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) thr
}
}
- if (healthReplicaNum < quorumReplicaNum) {
+ if (transactionState.isPublishTimeout() &&
healthReplicaNum > 0) {
+ // We can not do any thing except retrying,
+ // because publish task is assigned a version,
+ // and doris does not permit discontinuous
+ // versions.
+ //
+ // If a timeout happens, it means that the
rowset
+ // that are being publised exists on a few
replicas we should go
+ // ahead, otherwise data may be lost and thre
Review Comment:
And why data will be lost?
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -941,7 +941,20 @@ public void finishTransaction(long transactionId,
Set<Long> errorReplicaIds) thr
}
}
- if (healthReplicaNum < quorumReplicaNum) {
+ if (transactionState.isPublishTimeout() &&
healthReplicaNum > 0) {
+ // We can not do any thing except retrying,
+ // because publish task is assigned a version,
+ // and doris does not permit discontinuous
+ // versions.
+ //
+ // If a timeout happens, it means that the
rowset
+ // that are being publised exists on a few
replicas we should go
+ // ahead, otherwise data may be lost and thre
Review Comment:
```suggestion
// ahead, otherwise data may be lost and the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
